Enable all tests on MS-Windows and run them during CI #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please consider patch to enable the two missing tests under windows and run all windows ext tests during CI. This is part of #61.
I took the library to change the
whitespace-test/jvm opts
test to test for outer level whitespaces correctness, e.g.-Dfoo=foo bar
then check forfoo="foo bar"
, instead of the very elusive quoted space-Dfoo="foo bar"
and then check forfoo="\"foo bar"\"
. The test seem to check for the basic white space case and does not require the extra complicated case with inner quotes, but I can as well be very wrong. I could not think of a general case where the double would be required in passing jvm options. It gets extremely tricky to be able to have Java to accept embedded spaces on windows.It turns out that to take inner space quoting in the
main opts
, other than being more complicated on windows, has changed in Java 17, and thus requires extra escaping as reflected in the updated test.Other than that, I used URIs for the temp files because the path separators
\
on windows, are taken as escape characters in the strings.I have also started migrated the
script
tobb.edn
, let me know if you would like me to include that in this PR (if accepted) or create another one.Thanks