Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When invoked from non-project directory, local jars cause classpath to be generated always #101

Closed
cursive-ide opened this issue Jun 8, 2023 · 3 comments · Fixed by #105

Comments

@cursive-ide
Copy link
Contributor

When invoking deps.clj from a directory which is not the project root, *dir* can be bound to indicate to the script which directory the project is in. If a deps.edn files contains local jars added as follows:

{:paths ["local.jar"]}

then the classpath is always recalculated. The offending code is here. If the path to the file is relative, it should be absolutised relative to *dir*.

borkdude added a commit that referenced this issue Jun 8, 2023
@borkdude
Copy link
Owner

borkdude commented Jun 8, 2023

I think I've fixed it, but will re-open until you've provided a (programmatic) repro that we can include as a test.

@borkdude borkdude reopened this Jun 8, 2023
@borkdude
Copy link
Owner

@cursive-ide Do you still have the repro for this? Just a bit of code would do, I can write the test for it.

cursive-ide pushed a commit to cursive-ide/deps.clj that referenced this issue Jun 15, 2023
@cursive-ide cursive-ide mentioned this issue Jun 15, 2023
3 tasks
@cursive-ide
Copy link
Contributor Author

Sorry for the delay, #105 has a test for this. I checked that it fails with the old code and passes with the new version.

borkdude pushed a commit that referenced this issue Jun 15, 2023
Fixes #101

Co-authored-by: Colin Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants