Skip to content

Commit

Permalink
composebox: Use SafeAreaView in ComposeBox
Browse files Browse the repository at this point in the history
Fixes zulip#3066

Previous approach almost worked correctly, but there was one
case it didn't - when the keyboard did pop on an iPhone, the
bottom space was sill there, though it shouldn't, as the keyboard
is located over the `Home Indicator`.
  • Loading branch information
borisyankov committed May 29, 2019
1 parent eac44d3 commit 6adefbf
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/compose/ComposeBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import type {
InputSelection,
UserOrBot,
Dispatch,
Dimensions,
} from '../types';
import { connect } from '../react-redux';
import {
Expand Down Expand Up @@ -50,7 +49,6 @@ import AutocompleteView from '../autocomplete/AutocompleteView';
type SelectorProps = {|
auth: Auth,
usersByEmail: Map<string, UserOrBot>,
safeAreaInsets: Dimensions,
isAdmin: boolean,
isAnnouncementOnly: boolean,
isSubscribed: boolean,
Expand Down Expand Up @@ -317,7 +315,6 @@ class ComposeBox extends PureComponent<Props, State> {
narrow,
usersByEmail,
editMessage,
safeAreaInsets,
isAdmin,
isAnnouncementOnly,
isSubscribed,
Expand All @@ -331,7 +328,6 @@ class ComposeBox extends PureComponent<Props, State> {

const placeholder = getComposeInputPlaceholder(narrow, auth.email, usersByEmail);
const style = {
paddingBottom: safeAreaInsets.bottom,
backgroundColor: 'rgba(127, 127, 127, 0.1)',
};

Expand Down Expand Up @@ -406,7 +402,6 @@ class ComposeBox extends PureComponent<Props, State> {
export default connect((state, props): SelectorProps => ({
auth: getAuth(state),
usersByEmail: getActiveUsersByEmail(state),
safeAreaInsets: getSession(state).safeAreaInsets,
isAdmin: getIsAdmin(state),
isAnnouncementOnly: getIsActiveStreamAnnouncementOnly(state, props.narrow),
isSubscribed: getIsActiveStreamSubscribed(state, props.narrow),
Expand Down

0 comments on commit 6adefbf

Please sign in to comment.