-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gaps in data (null, NaN, etc) #46
base: master
Are you sure you want to change the base?
Conversation
This helps development when using npm 3, which does not install peers automatically.
That is a really good idea. 👍 |
# Conflicts: # package.json
SparklinesLine and SparklinesCurve received a DRY treatment via the addition of SparklinesSegmentContainer and defaults.js. Includes tests and an updated demo page.
Whew! OK, I think this thing is quite complete. Any thoughts? As for me, I still wonder about the |
I agree, this being the default options, sounds like a good idea. |
I implemented this and one existing test was broken - this one. I'll rebase this on master in a minute, so we can use Travis here again. It's your call, @borisyankov. As a user, I'm comfortable with this change, but I'm just one data point. Having this on by default should probably be semver-major to avoid breaking others' code. |
@borisyankov Any thoughts on getting this merged? I could use it :) |
@motiz88 any interest in getting this current with |
@motiz88 Has been a while. I am committed to merging it into master. |
I'm submitting this PR to gauge interest in the completed feature and get some feedback before I go ahead and implement it all.
The idea is to graphically represent data with in-band
null
s,NaN
s or infinite values by drawing the valid (finite numeric) segments separately from one another.