Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined VRDisplay when using webvr-boilerplate in three-vr-boilerplate #137

Open
Xaxis opened this issue Apr 27, 2016 · 7 comments
Open

Comments

@Xaxis
Copy link

Xaxis commented Apr 27, 2016

I've been playing around with making a boilerplate of webvr-boilerplate, one that allows me to spin up webvr/three.js based apps and develop them in the manner I'm accustomed to these days: using require, backbone, sass, etc. The project is https://github.com/Xaxis/three-vr-boilerplate.

The problem I'm having is VRDisplay is not defined coming from line 401 in webvr-manager here. The bulk of my project code related to webvr-boilerplate initialization is here.

Could someone inform me a bit more regarding where VRDisplay is defined normally? Could this be a conflict with require.js due to the fact that I'm loading a project that is also using require as a module loader? Any help or insight would be hugely appreciated.

@borismus
Copy link
Owner

You probably need to use the webvr-polyfill. Or a special build that
exposes WebVR API.

On Wed, Apr 27, 2016, 1:09 PM Wil Neeley [email protected] wrote:

I've been playing around with making a boilerplate of webvr-boilerplate,
one that allows me to spin up webvr/three.js based apps and develop them in
the manner I'm accustomed to these days: using require, backbone, sass,
etc. The project is https://github.com/Xaxis/three-vr-boilerplate.

The problem I'm having is VRDisplay is not defined coming from line 401 in
webvr-manager here
https://github.com/borismus/webvr-boilerplate/blob/master/build/webvr-manager.js#L401.
The bulk of my project code related to webvr-boilerplate initialization is
here
https://github.com/Xaxis/three-vr-boilerplate/blob/master/app/js/libs/native/main/main.js
.

Could someone inform me a bit more regarding where VRDisplay is defined
normally? Could this be a conflict with require.js due to the fact that I'm
loading a project that is also using require as a module loader? Any help
or insight would be hugely appreciated.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#137

@nhirata
Copy link

nhirata commented May 5, 2016

Which browser were you using? On the Nightly of Firefox, I'm experiencing the same thing. I don't experience that with Chromium without the headset (right now Chromium doesn't work with Oculus Runtime 1.3). With older version of Firefox, I don't experience the issue, but I can't see it within the browser. I filed bug 1269057 for the Firefox Nightly and will try to dig into it some.

@Xaxis
Copy link
Author

Xaxis commented May 5, 2016

I'm experiencing the issue in:
Chrome 50.0.2661.86
Firefox 46.0.1
Firefox Nightly

@brianpeiris
Copy link
Contributor

Firefox Nightly does not support WebVR 1.0 yet (which implements VRDisplay). The MozVR team is working on supporting 1.0 at the moment.
Until then, if you want to support Nightly, you'll have to use v0.3.8

@brianpeiris
Copy link
Contributor

This is also covered by #127

@nhirata
Copy link

nhirata commented May 5, 2016

Ah. that answers the question. For the Nightly, WebVR 1.0 is being currently implemented, you can see the work being done in this bug : https://bugzilla.mozilla.org/show_bug.cgi?id=1250244

Brian, would you think it's feasible to do a fall back if VRDisplay is null to fall back to VRDevice?

Xaxis, Not sure about Chrome. I believe they have to update with Oculus runtime 1.3.2; With the 46.0.1, are you using the addon?

@brianpeiris
Copy link
Contributor

We can close this, since Firefox supports WebVR 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants