Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: querying inactive relay in update_ui() #326

Merged
merged 1 commit into from
Nov 25, 2024
Merged

FIX: querying inactive relay in update_ui() #326

merged 1 commit into from
Nov 25, 2024

Conversation

RobinTail
Copy link
Collaborator

Fixes #325

@RobinTail RobinTail added the bug Something isn't working label Nov 25, 2024
@RobinTail RobinTail changed the title FIX: quering unactive relay in update_ui(). FIX: querying inactive relay in update_ui() Nov 25, 2024
@RobinTail RobinTail marked this pull request as ready for review November 25, 2024 19:32
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 1055d45 on issue-325-update-ui-unactive-relay-v5
into 9ddbdf6 on develop.

RobinTail
RobinTail commented Nov 25, 2024
View reviewed changes
Copy link
Collaborator Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to skip relays here, because historically that method informs the UI on ALL relays, even on inactive ones.
This should fix the issue.

@RobinTail RobinTail merged commit 9039563 into develop Nov 25, 2024
16 checks passed
@RobinTail RobinTail mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @coveralls