Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise use of setZero() and add comments #314

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

jlblancoc
Copy link
Member

@jlblancoc jlblancoc commented May 18, 2020

This is a follow up of #310 , trying to minimize the changes wrt former behavior and improve the docs.
cc: @dellaert

Mainly, the idea is that constructors taking lists of blocks could fill with zeros so if a block is not provided, it's taken for granted that it will be filled with zeros (this is now documented, and also fixes the original x32 bug, by the way), while the third constructor modified in the former PR, taking as input a Matrix, doesn't actually need the setZero() since it will be immediately after that overwritten, so it's a potential waste of time.


This change is Reviewable

@dellaert
Copy link
Member

Hmmmm. Since it is a matrix, and we use Eigen for matrices, I actually think more and more its confusing to have different semantics from Eigen. Is it so much harder to fix the original bug, now that we know what the cause is? If needed, a setZero method could be added if it's not already there. To flush out current and future problems we could ad a CI check that initializes to Nan.

@jlblancoc jlblancoc mentioned this pull request Jun 19, 2020
26 tasks
@dellaert dellaert merged commit 489e8f0 into develop Jun 19, 2020
@dellaert dellaert deleted the fix/alternativeFixSymmetricBlockMatrix branch July 9, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants