More precise use of setZero() and add comments #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #310 , trying to minimize the changes wrt former behavior and improve the docs.
cc: @dellaert
Mainly, the idea is that constructors taking lists of blocks could fill with zeros so if a block is not provided, it's taken for granted that it will be filled with zeros (this is now documented, and also fixes the original x32 bug, by the way), while the third constructor modified in the former PR, taking as input a
Matrix
, doesn't actually need thesetZero()
since it will be immediately after that overwritten, so it's a potential waste of time.This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)