Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some wrapper warnings #260

Merged
merged 7 commits into from
Mar 29, 2020
Merged

Fixed some wrapper warnings #260

merged 7 commits into from
Mar 29, 2020

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Mar 23, 2020 •
edited by dellaert
Loading

Due to

  • Eigen alignment.
  • Wrapper code being too long.
  • Exceptions which weren't reference.

This change is Reviewable

@varunagrawal varunagrawal added the bugfix Fixes an issue or bug label Mar 23, 2020
@varunagrawal varunagrawal requested a review from dellaert March 23, 2020 03:37
@varunagrawal varunagrawal self-assigned this Mar 23, 2020
ProfFan
ProfFan approved these changes Mar 26, 2020
View reviewed changes
gtsam/nonlinear/utilities.h Show resolved Hide resolved
@varunagrawal varunagrawal requested a review from ProfFan March 28, 2020 22:20
@varunagrawal
Copy link
Collaborator Author

@ProfFan one last review and if you think this looks good, I can merge it in.

@varunagrawal varunagrawal merged commit 9361d5b into develop Mar 29, 2020
@varunagrawal varunagrawal deleted the fix/cmake-wrapper-warnings branch March 29, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @ProfFan