RFC: Adding a number of docker images #241
Conversation
| @@ -0,0 +1,18 @@ | |||
| # Get the base Ubuntu/GTSAM image from Docker Hub | |||
| FROM dellaert/ubuntu-gtsam-python:bionic | |||
There was a problem hiding this comment.
Should this be a common namespace like borglab?
It would help with maintenance and management.
| @@ -0,0 +1,29 @@ | |||
| # Get the base Ubuntu/GTSAM image from Docker Hub | |||
| FROM dellaert/ubuntu-gtsam:bionic | |||
| FROM dellaert/ubuntu-gtsam:bionic | ||
|
|
||
| # Install pip | ||
| RUN apt-get install -y python-pip python-dev |
There was a problem hiding this comment.
This should say python3-pip and python3-dev. Ideally, we should be using pyenv to make python version management easy.
| RUN apt-get install -y python-pip python-dev | ||
|
|
||
| # Install python wrapper requirements | ||
| RUN pip install -r /usr/src/gtsam/cython/requirements.txt |
There was a problem hiding this comment.
We need to check if pip invokes the built in pip2 (which is deprecated) or pip3.
There was a problem hiding this comment.
what about using python3 -m pip install ... to be 100% sure?
There was a problem hiding this comment.
That would be the best option. 🙂
docker/ubuntu-gtsam/Dockerfile
Outdated
|
|
||
| # Clone GTSAM | ||
| WORKDIR /usr/src/ | ||
| RUN git clone https://bitbucket.org/gtborg/gtsam.git |
There was a problem hiding this comment.
Needs to be updated to use github and perhaps pull the develop branch which has a lot of new niceness?
| apt-get install -y git | ||
|
|
||
| # Install compiler | ||
| RUN apt-get install -y build-essential |
There was a problem hiding this comment.
This and the previous command can be merged to finish in a single download.
|
@jlblancoc what's your take on this PR? :-) |
Awesome, I made it work!
See the last commits, though, with a couple of details I needed to change to fix it. |
These were a number of github images I created to support assignments in a class, and I believe they might be valuable by themselves. Let's discuss whether this collection and structure for the docker folder is the right way to go.
This change is