Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Hybrid Inference #1986

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Improvements to Hybrid Inference #1986

merged 3 commits into from
Jan 22, 2025

Conversation

varunagrawal
Copy link
Collaborator

Made some improvements over the weekend that helped with debugging and writing examples.

  1. Separate mpe() method for discrete max-product.
  2. DiscreteValues::insert to add only a single key-value pair.
  3. Format DiscreteMarginals.h.

@varunagrawal varunagrawal requested a review from dellaert January 21, 2025 21:39
@varunagrawal varunagrawal self-assigned this Jan 21, 2025
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@varunagrawal varunagrawal merged commit 7dfdde3 into develop Jan 22, 2025
35 checks passed
@varunagrawal varunagrawal deleted the improvements branch January 22, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants