Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg 1.4: drop or keep the buster-based binary? #8171

Closed
ThomasWaldmann opened this issue Mar 30, 2024 · 3 comments
Closed

borg 1.4: drop or keep the buster-based binary? #8171

ThomasWaldmann opened this issue Mar 30, 2024 · 3 comments
Assignees
Milestone

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Mar 30, 2024

The pyinstaller-made fat binaries offered on github releases page are built on debian systems.

They can be usually used on systems with a compatible glibc, thus for compatibility with older systems, an old build system is needed.

But, Debian Buster is running out of LTS support soon: https://wiki.debian.org/LTS

Also, since I removed the bundled xxhash source code from borg 1.4, the build on buster broke, because libxxhash-dev (0.6.5) can not be discovered via pkg-config. This feature has been added later there (0.8 or so) and was initially broken, thus needs 0.8.2 or a fixed package.

So there might be no buster-based borg 1.4 binary (glibc 2.28), unless this is fixed / worked around somehow.

Debian Bullseye offers glibc 2.31, Debian Bookworm offers glibc 2.36.

Considering borg 1.4 is quite similar to borg 1.2, users of older systems can also use the borg 1.2 binaries.

@ThomasWaldmann ThomasWaldmann added this to the 1.4.0rc1 milestone Mar 30, 2024
@ThomasWaldmann
Copy link
Member Author

Looks like there is no interest in a buster binary, so we'll drop it.

ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Apr 22, 2024
@ThomasWaldmann ThomasWaldmann self-assigned this Apr 22, 2024
ThomasWaldmann added a commit that referenced this issue Apr 22, 2024
@ThomasWaldmann
Copy link
Member Author

glibc 2.28 is used by RHEL 8.

@ThomasWaldmann ThomasWaldmann modified the milestones: 1.4.0rc1, 1.4.0 May 28, 2024
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented May 28, 2024

About the required xxhash version, from the change log:

upgrade bundled xxhash to 0.7.3, #4891

0.7.2 is the minimum requirement for correct operations on ARMv6 in non-fixup mode, where unaligned memory accesses cause bus errors.

0.7.3 adds some speedups and libxxhash 0.7.3 even has a pkg-config file now.

debian buster

... only has 0.6.5, but for our x86-64 pyinstaller-based fat binary, guess that is good enough.

So, guess the easiest fix for the debian buster box is to use the BORG_LIBXXHASH_PREFIX env var to point to debian's libxxhash.

@ThomasWaldmann ThomasWaldmann changed the title borg 1.4: drop buster-based binary? borg 1.4: drop or keep the buster-based binary? Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant