Skip to content

Commit

Permalink
ci: fixing valgrind suppressions and reformat valgrind yml
Browse files Browse the repository at this point in the history
  • Loading branch information
Boquan Fang committed Sep 17, 2024
1 parent c02588a commit d4d0d52
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 27 deletions.
27 changes: 1 addition & 26 deletions codebuild/spec/buildspec_valgrind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,30 +15,6 @@ version: 0.2

batch:
build-list:
- identifier: clang_awslc
env:
compute-type: BUILD_GENERAL1_LARGE
variables:
S2N_LIBCRYPTO: awslc
COMPILER: clang
- identifier: clang_openssl_3_0
env:
compute-type: BUILD_GENERAL1_LARGE
variables:
S2N_LIBCRYPTO: openssl-3.0
COMPILER: clang
- identifier: clang_openssl_1_1_1
env:
compute-type: BUILD_GENERAL1_LARGE
variables:
S2N_LIBCRYPTO: openssl-1.1.1
COMPILER: clang
- identifier: clang_openssl_1_0_2
env:
compute-type: BUILD_GENERAL1_LARGE
variables:
S2N_LIBCRYPTO: openssl-1.0.2
COMPILER: clang
- identifier: gcc_awslc
env:
compute-type: BUILD_GENERAL1_LARGE
Expand Down Expand Up @@ -73,6 +49,5 @@ phases:
on-failure: ABORT
commands:
- |
S2N_DEBUG=true S2N_VALGRIND=1 \
CTEST_PARALLEL_LEVEL=$(nproc) CTEST_OUTPUT_ON_FAILURE=1 ctest -T memcheck \
S2N_VALGRIND=1 CTEST_PARALLEL_LEVEL=$(nproc) CTEST_OUTPUT_ON_FAILURE=1 ctest -T memcheck \
--test-dir build ARGS="-output-on-failure"
15 changes: 14 additions & 1 deletion tests/unit/valgrind.suppressions
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
# It looks like valgrind may generate false positives on pthreads: https://stackoverflow.com/a/13132968
{
pthread_false_positive
pthred_false_positive
Memcheck:Leak
match-leak-kinds: possible
fun:calloc
fun:allocate_dtv
fun:_dl_allocate_tls
fun:allocate_stack
fun:pthread_create@@GLIBC_2.2.5
fun:main
}
# Append valgrind suppression for ubuntu22
{
pthread_false_positive_ubuntu22
Memcheck:Leak
match-leak-kinds: possible
fun:calloc
Expand Down Expand Up @@ -33,6 +45,7 @@
fun:dlerror_run
fun:__libc_dlopen_mode
fun:__libc_unwind_link_get
fun:__libc_unwind_link_get
fun:backtrace
...
fun:main
Expand Down

0 comments on commit d4d0d52

Please sign in to comment.