Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): allow filtering on false values. Fixes #2485 #2544

Merged
merged 3 commits into from
Feb 13, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Feb 13, 2019

Description of Pull Request:

Fixes private method toString(...) so that boolean false values can be filtered on.

Also adds special case for Date objects (using date's native toString method) and sorting of date objects.

Fixes #2485

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #2544 into dev will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #2544      +/-   ##
=========================================
- Coverage   70.7%   70.67%   -0.04%     
=========================================
  Files        172      172              
  Lines       3168     3168              
  Branches     919      919              
=========================================
- Hits        2240     2239       -1     
- Misses       675      676       +1     
  Partials     253      253
Impacted Files Coverage Δ
src/components/table/table.js 72.8% <100%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c6b2d...68da867. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(table): allow filtering on false values fix(table): allow filtering on false values. Fixes #2485 Feb 13, 2019
@tmorehouse tmorehouse merged commit 79315d6 into dev Feb 13, 2019
@tmorehouse tmorehouse deleted the tmorehouse/table-filter branch February 13, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table cannot filter for boolean false
1 participant