Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug[b-link]: Global active-class and exact-active-class overridden by prop defaults #2387

Closed
tmorehouse opened this issue Jan 4, 2019 · 0 comments · Fixed by #2388
Closed

bug[b-link]: Global active-class and exact-active-class overridden by prop defaults #2387

tmorehouse opened this issue Jan 4, 2019 · 0 comments · Fixed by #2388
Labels
Priority: Medium Type: Bug

Comments

@tmorehouse
Copy link
Member

When a global active-class and exact-active-class are defined in vue-router or nuxt.js, <b-link> (and all components that inherit from <b-link>) is overriding these by specifically defaulting the props to the Bootstrap V4 class active.

Related issue #1967

Changing the props to default to undefined would remedy this, but might be constituted as a breaking change
@tmorehouse tmorehouse changed the title bug[b-link]: Global link-active-class and link-exact-active-class bug[b-link]: Global active-class and exact-active-class overridden by prop defaults Jan 4, 2019
tmorehouse added a commit that referenced this issue Jan 4, 2019
@tmorehouse
fix(link): remove default values for active-class and exact-active-class
dbd9ba2 
Removes the default values (setting to `undefined`) for props `active-class` and `exact-active-class`, so that the globally configured values can be used by default.

Affects `b-link`, `b-button`, `b-dropdown-item` and other components that build on `b-link`.

Fixes #2387
@tmorehouse tmorehouse mentioned this issue Jan 4, 2019
Merged
18 tasks
tmorehouse added a commit that referenced this issue Jan 6, 2019
@tmorehouse
fix(router-link): remove default values for active-class and exact-ac…
e3e30b8 
…tive-class (Fixes #2387) (#2388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Type: Bug
Projects
None yet
Milestone
No milestone
1 participant
@tmorehouse