Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mounting modal forces reflow of page #1800

Closed
libre-man opened this issue May 6, 2018 · 0 comments · Fixed by #2165
Closed

Mounting modal forces reflow of page #1800

libre-man opened this issue May 6, 2018 · 0 comments · Fixed by #2165
Assignees
@tmorehouse
Labels
Priority: Medium Type: Perf

Comments

@libre-man
Copy link

  • Operating system and version: Debian Testing
  • Browser and version: Chromium 62.0.3202.89, but probably others too.

When mounting a modal the getScrollbarWidth function is called. This function however triggers a reflow of the current page. Please make it possible to only call this function when to modal is actually displayed.
@tmorehouse tmorehouse self-assigned this Nov 13, 2018
tmorehouse added a commit that referenced this issue Nov 13, 2018
@tmorehouse
perf(modal): Get scrollbar width just before modal opens rather than …
f4f71f3 
…mount (fixes #1800)

Moves the scroll bar measurement to just before the modal opens, rather than during mount().

Prevents the page from reflowing until modal opens
@tmorehouse tmorehouse mentioned this issue Nov 13, 2018
Merged
17 tasks
tmorehouse added a commit that referenced this issue Nov 13, 2018
@tmorehouse
perf(modal): Get scrollbar width just before modal opens rather than …
e1729b4 
…mount (fixes #1800) (#2165)

Moves the scroll bar measurement to just before the modal opens, rather than during mount().

Prevents the page from reflowing until modal opens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmorehouse tmorehouse

Labels
Priority: Medium Type: Perf
Projects
None yet
Milestone
No milestone
2 participants
@tmorehouse @libre-man