Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injectable S3Client factory #11

Closed
andrus opened this issue Oct 12, 2021 · 0 comments
Closed

Injectable S3Client factory #11

andrus opened this issue Oct 12, 2021 · 0 comments
Milestone
3.0.M1

Comments

@andrus
Copy link
Contributor

andrus commented Oct 12, 2021 •
edited
Loading

SDK v2 only.

Currently S3Client is a singleton, and this doesn't allow to e.g. access buckets that are not in the AWS profile default region. So let's instead provide a factory to create S3Client on demand with either the default or a specified region.

Check #10 before implementing this.
@andrus andrus mentioned this issue Oct 12, 2021
Open
@andrus andrus changed the title Injectable AmazonS3 factory Injectable S3Client factory Oct 15, 2021
andrus added a commit that referenced this issue Jun 13, 2022
@andrus
Injectable S3Client factory #11
fd470f9
@andrus andrus added this to the 3.0.M1 milestone Jun 13, 2022
@andrus andrus closed this as completed Jun 13, 2022
andrus added a commit that referenced this issue Jun 13, 2022
@andrus
Injectable S3Client factory #11
266d61b 
.. caching the default client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.M1
Development

No branches or pull requests
1 participant
@andrus