Skip to content
This repository has been archived by the owner on Feb 27, 2018. It is now read-only.

Improve removing the library path #324

Merged
merged 2 commits into from
Feb 24, 2015
Merged

Improve removing the library path #324

merged 2 commits into from
Feb 24, 2015

Conversation

waltarix
Copy link
Contributor

Fixes #148.

@waltarix
Copy link
Contributor Author

Oops, sorry.
This fix uses go.Unsetenv that has been introduced in Go 1.4.

If project came to use Go 1.4, please reopen this PR and merge it.

@waltarix waltarix closed this Dec 24, 2014
@tianon
Copy link
Contributor

tianon commented Dec 24, 2014

I'm not opposed to using Go 1.4, especially if it means actual fixes to problems like this one!

@tianon tianon reopened this Dec 24, 2014
@tianon tianon mentioned this pull request Dec 24, 2014
@tianon
Copy link
Contributor

tianon commented Dec 24, 2014

#325 👍

@tianon
Copy link
Contributor

tianon commented Feb 6, 2015

This one is back on the table now that we're on Go 1.4!

@waltarix still interested in carrying this one? We'll likely have to remove the - 1.3.3 from .travis.yml that I just added, but I'm OK with that, since this fixes a real issue. I just wanted to make sure that removing Go 1.3 support became a conscious decision. 😄

@waltarix
Copy link
Contributor Author

waltarix commented Feb 7, 2015

Thank you for the good news! 😁

Yes, I'm still interested in this one.
All right. Please let me know when Go 1.3 support is actually removed. then I'll rebase this PR.

@tianon
Copy link
Contributor

tianon commented Feb 23, 2015

I'd say that we might as well remove it here in this PR directly, since this is the feature we'd remove it for. 👍

@waltarix
Copy link
Contributor Author

I see.
Now I've created a new commit that removes Go 1.3 support, and also rebased!

@tianon
Copy link
Contributor

tianon commented Feb 24, 2015

Nice! LGTM

cc @gmlewis @Moghedrin

@gmlewis
Copy link
Contributor

gmlewis commented Feb 24, 2015

LGTM

gmlewis added a commit that referenced this pull request Feb 24, 2015
Improve removing the library path
@gmlewis gmlewis merged commit 265d633 into boot2docker:master Feb 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boot2docker-vm setup fails due to DYLD_LIBRARY_PATH settings
3 participants