Add support for client binary on upgrade #242

nathanleclaire · 2014-08-27T03:59:18Z

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit @tianon

SvenDowideit · 2014-08-28T00:01:46Z

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

nathanleclaire · 2014-08-28T01:17:27Z

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

SvenDowideit · 2014-08-28T02:52:58Z

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

nathanleclaire · 2014-09-01T22:52:12Z

OK, I have added the requested changes:

only download client binary if user's version lags behind latest (non-RC) tag
skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

SvenDowideit · 2014-09-02T00:36:16Z

cmds.go

+	url := "https://api.github.com/repos/docker/docker/tags"
+	tag, err := getLatestReleaseName(url)
+	if err != nil {
+		return fmt.Errorf("Error making Github API call to get docker client binary version: %s", err)


Capitalise Docker or you'll make James cry.

SvenDowideit · 2014-09-02T00:39:43Z

neat - do you want to do the same for the boot2docker binary? >:}

SvenDowideit · 2014-09-02T00:40:29Z

cmds.go

+		}
+		fmt.Printf("Success: downloaded %s\n\tto %s\n", binaryUrl, path)
+	} else {
+		fmt.Println("docker client is up to date, skipping client upgrade...")


Docker, and go on, tell them the version they have

SvenDowideit · 2014-09-02T05:20:40Z

this would close boot2docker/osx-installer#63

nathanleclaire · 2014-09-02T17:51:50Z

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

nathanleclaire · 2014-09-02T19:12:04Z

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

tianon · 2014-09-02T22:35:21Z

cmds.go

@@ -3,6 +3,7 @@ package main
 import (
 	"encoding/json"
 	"fmt"
+


What's this blank line here for?

It's an artifact from vim-go (run goimports on save hook).

SvenDowideit · 2014-10-14T03:27:22Z

@nathanleclaire darn - i presume this got lost in the busyness?

nathanleclaire · 2014-10-14T03:54:09Z

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

If mount fails, let's "modprobe" the partition type and try again

nathanleclaire · 2014-12-13T04:17:44Z

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

tianon · 2014-12-16T04:47:35Z

cmds.go

@@ -3,6 +3,9 @@ package main
 import (
 	"encoding/json"
 	"fmt"
+	"net/http"
+


Why the random blank line here? 😄

goimports as an editor hook >_>

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

Must've accidentally added it - I'll fix

tianon · 2014-12-16T04:51:56Z

cmds.go

+		clientArch = "x86_64"
+	// todo: wishful thinking?
+	case "arm":
+		clientArch = "armv7l"


Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

tianon · 2014-12-16T05:01:05Z

Lots of little nits, but overall I'm a fan. 👍

SvenDowideit · 2014-12-16T07:02:58Z

I'm a big fan :)

`boot2docker upgrade` will support the Docker client binary, boot2docker-cli binary, and boot2docker ISO now. Signed-off-by: Nathan LeClaire <[email protected]>

nathanleclaire · 2014-12-16T21:37:23Z

Nice revised with the feedback from review. @SvenDowideit @tianon PTAL

Signed-off-by: Nathan LeClaire <[email protected]>

tianon · 2014-12-16T21:54:34Z

README.md

+
+To do so, run the `boot2docker upgrade` command.
+
+```


Can you add console here so we get nice highlights? 👼

ie:

$ command here output here

Definitely!

Signed-off-by: Nathan LeClaire <[email protected]>

tianon · 2014-12-16T22:54:43Z

LGTM

daghack · 2014-12-16T23:01:07Z

LGTM

Add support for client binary on upgrade

SvenDowideit reviewed Sep 2, 2014
View reviewed changes

tianon reviewed Sep 2, 2014
View reviewed changes

SvenDowideit mentioned this pull request Oct 17, 2014

boot2docker upgrade should warn if the cli is outdated #294

Closed

SvenDowideit pushed a commit to SvenDowideit/boot2docker-cli that referenced this pull request Nov 10, 2014

Merge pull request boot2docker#242 from tianon/mount-sucks

76e08ba

If mount fails, let's "modprobe" the partition type and try again

nathanleclaire force-pushed the upgrade_client_binary branch 2 times, most recently from e852ac8 to 46ea9a9 Compare December 13, 2014 04:11

tianon reviewed Dec 16, 2014
View reviewed changes

Add support for upgrading binaries

5d67082

`boot2docker upgrade` will support the Docker client binary, boot2docker-cli binary, and boot2docker ISO now. Signed-off-by: Nathan LeClaire <[email protected]>

nathanleclaire force-pushed the upgrade_client_binary branch 2 times, most recently from 69e84dd to 11c898c Compare December 16, 2014 21:33

nathanleclaire force-pushed the upgrade_client_binary branch from 11c898c to 59a7970 Compare December 16, 2014 21:38

Add small doc section on upgrade

4a02eca

Signed-off-by: Nathan LeClaire <[email protected]>

nathanleclaire force-pushed the upgrade_client_binary branch from 59a7970 to 4a02eca Compare December 16, 2014 21:41

tianon reviewed Dec 16, 2014
View reviewed changes

Implement a few things from code review feedback

b931320

Signed-off-by: Nathan LeClaire <[email protected]>

nathanleclaire force-pushed the upgrade_client_binary branch from a173a35 to b931320 Compare December 16, 2014 22:05

nathanleclaire added 2 commits December 16, 2014 14:07

go vet

051d766

Signed-off-by: Nathan LeClaire <[email protected]>

Revise clobber flag default code

6b12c9b

Signed-off-by: Nathan LeClaire <[email protected]>

tianon added a commit that referenced this pull request Dec 16, 2014

Merge pull request #242 from nathanleclaire/upgrade_client_binary

d2f3a3b

Add support for client binary on upgrade

tianon merged commit d2f3a3b into boot2docker:master Dec 16, 2014

drewwells mentioned this pull request Dec 17, 2014

boot2docker 1.4.0 Homebrew/legacy-homebrew#35037

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for client binary on upgrade #242

Add support for client binary on upgrade #242

nathanleclaire commented Aug 27, 2014

SvenDowideit commented Aug 28, 2014

nathanleclaire commented Aug 28, 2014

SvenDowideit commented Aug 28, 2014

nathanleclaire commented Sep 1, 2014

SvenDowideit Sep 2, 2014

nathanleclaire Sep 2, 2014

SvenDowideit commented Sep 2, 2014

SvenDowideit Sep 2, 2014

SvenDowideit commented Sep 2, 2014

nathanleclaire commented Sep 2, 2014

nathanleclaire commented Sep 2, 2014

tianon Sep 2, 2014

nathanleclaire Sep 2, 2014

SvenDowideit commented Oct 14, 2014

nathanleclaire commented Oct 14, 2014

nathanleclaire commented Dec 13, 2014

tianon Dec 16, 2014

nathanleclaire Dec 16, 2014

tianon Dec 16, 2014

nathanleclaire Dec 16, 2014

tianon Dec 16, 2014

tianon Dec 16, 2014

tianon commented Dec 16, 2014

SvenDowideit commented Dec 16, 2014

nathanleclaire commented Dec 16, 2014

tianon Dec 16, 2014

nathanleclaire Dec 16, 2014

tianon commented Dec 16, 2014

daghack commented Dec 16, 2014

Add support for client binary on upgrade #242

Add support for client binary on upgrade #242

Conversation

nathanleclaire commented Aug 27, 2014

SvenDowideit commented Aug 28, 2014

nathanleclaire commented Aug 28, 2014

SvenDowideit commented Aug 28, 2014

nathanleclaire commented Sep 1, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SvenDowideit commented Sep 2, 2014

Choose a reason for hiding this comment

SvenDowideit commented Sep 2, 2014

nathanleclaire commented Sep 2, 2014

nathanleclaire commented Sep 2, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SvenDowideit commented Oct 14, 2014

nathanleclaire commented Oct 14, 2014

nathanleclaire commented Dec 13, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tianon commented Dec 16, 2014

SvenDowideit commented Dec 16, 2014

nathanleclaire commented Dec 16, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tianon commented Dec 16, 2014

daghack commented Dec 16, 2014