Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --scm-base-url more fool-proof #95

Merged

Conversation

ledo01
Copy link
Contributor

@ledo01 ledo01 commented May 26, 2024

Strip scheme prefix for --scm-base-url option so that https://gitlab.com and gitlab.com are accepted.

Fixes #93

ledo01 added 2 commits May 25, 2024 23:07
Strip scheme prefix for `--scm-base-url` option so that
`https://gitlab.com` and `gitlab.com` are accepted.

Fixes boostsecurityio#93
@ledo01
Copy link
Contributor Author

ledo01 commented May 26, 2024

@fproulx-boostsecurity, took a stab at the issue for fun.

I was able to run the cli with https:gitlab.com/ and just gitlab.com with this change.

@ledo01 ledo01 marked this pull request as ready for review May 26, 2024 03:19
@ledo01 ledo01 requested a review from a team as a code owner May 26, 2024 03:19
Copy link
Contributor

@SUSTAPLE117 SUSTAPLE117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the contribution @ledo01!

@SUSTAPLE117 SUSTAPLE117 merged commit ef0bd93 into boostsecurityio:main May 27, 2024
5 checks passed
@ledo01 ledo01 deleted the 93-make-scm-base-url-more-fool-proof branch May 27, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --scm-base-url more fool-proof
2 participants