Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type which are convertible to a number should not participate in arit… #609

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

jzmaddock
Copy link
Collaborator

…hmetic operator overloads.

Fixes #608

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3c9ff4d) to head (4fe16b7).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #609     +/-   ##
=========================================
- Coverage     94.1%   94.1%   -0.0%     
=========================================
  Files          274     274             
  Lines        28563   28563             
=========================================
- Hits         26874   26872      -2     
- Misses        1689    1691      +2     
Files Coverage Δ
...nclude/boost/multiprecision/detail/number_base.hpp 98.0% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9ff4d...4fe16b7. Read the comment docs.

@jzmaddock jzmaddock merged commit 2e81e42 into develop Mar 7, 2024
71 checks passed
@mborland
Copy link
Member

mborland commented Mar 7, 2024

Should we ask Marshall about merging this into master once it's permissible again?

@mborland mborland deleted the issue608 branch March 7, 2024 17:41
@jzmaddock
Copy link
Collaborator Author

Probably yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type convertibility to Backend is assumed true if type is convertible to number<Backend, et>
2 participants