-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try (with minimal effort) GCC4 in arithmetic tests #458
Conversation
The result of this PR so far is:
Rational why I include the final point here is because I noticed this point with great clarity for the first time here. |
Hi John (@jzmaddock) this thing is review-ready. I'll struggle no further on it until we reach a 4.8 consensus. At the moment there is no effort to fully incorporate 4.8. This PR in this state officially closes #429. You can, however, also choose to pursue this thread further. I'm OK with that too. Or later get back on it, or whatever? I do, however, really want the changes within and as sketched/described above. Also a few changes in Math needed, as these are bugs anyway, I'll PR them shortly. If you get a chance, please at your convenience, tell me what you think...? And we can move on. Cc: @mborland and @NAThompson |
Any feedback on this? It seems to be running green in CI. |
Sorry for the delay, yep, go for it! |
Thanks John. This PR ended up to not go entirely for GCC 4.8 and there is no 48. added run in CI. Multiprecision was pretty close to accepting 4.8, but a few small issues prevented that. GCC 4.8 did find some inconsistencies (mostly Cc: @mborland and @NAThompson |
No description provided.