Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fisher_f mode #976

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Fix fisher_f mode #976

merged 2 commits into from
Apr 14, 2023

Conversation

maitbayev
Copy link
Contributor

The mode for F-distribution is defined when df1 > 2 according to https://en.wikipedia.org/wiki/F-distribution. It is also reasonable since df2 * (df1 - 2) / (df1 * (df2 + 2)) becomes zero or negative when df1 <= 2

Verified

This commit was signed with the committer’s verified signature.
blittle Bret Little
The mode for F-distribution is defined when `df1 > 2` according to https://en.wikipedia.org/wiki/F-distribution. It is also reasonable since `df2 * (df1 - 2) / (df1 * (df2 + 2))` becomes zero or negative when `df1 <= 2`
Copy link
Member

@mborland mborland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the value the policy is reporting on failure this looks to be correct.

include/boost/math/distributions/fisher_f.hpp Outdated Show resolved Hide resolved
@maitbayev
Copy link
Contributor Author

@mborland Good catch. Addressed the comment

@mborland mborland merged commit 109a814 into boostorg:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants