Improve ccmath signbit and copysign #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzmaddock and @NAThompson this is good for review. It conditionally solves the issue of not supporting 0s and NANs brought up on the mailing list. |
jzmaddock
reviewed
Aug 22, 2022
jzmaddock
reviewed
Aug 22, 2022
jzmaddock
reviewed
Aug 22, 2022
|
@jzmaddock Would you like another look before I merge? I hit all of your comments in the latest commit. |
mborland
force-pushed
the
better_copysign
branch
from
b5618a0 to
48edf59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::bit_castor__builtin_bit_castwhen available to support signed zeros and NANs.