Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #810 #811

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Fix for issue #810 #811

merged 3 commits into from
Aug 4, 2022

Conversation

mborland
Copy link
Member

@mborland mborland commented Aug 4, 2022

Addresses 0 as null pointer constant and sign compare warnings as well.

@mborland mborland linked an issue Aug 4, 2022 that may be closed by this pull request
@jzmaddock
Copy link
Collaborator

The failure is unconnected but worrying (GCC-9 and gun++11 mode):

testing.capture-output ../../../bin.v2/libs/math/test/test_chatterjee_correlation.test/gcc-9/debug/link-static/threading-multi/visibility-hidden/test_chatterjee_correlation.run

====== BEGIN OUTPUT ======

Error at test_chatterjee_correlation.cpp:test_paper:130:

  Mollified relative error in float precision is 0.0561, which exceeds 0.012, error/tol  = 4.68.

  Expected: +0.828877568 = +0x1.a862a4p-1

  Computed: +0.884999990 = +0x1.c51eb8p-1

  ULP distance: +941578

malloc(): invalid next size (unsorted)

Aborted (core dumped)

@jzmaddock
Copy link
Collaborator

@jzmaddock
Copy link
Collaborator

See also #812 which extends this PR with further tests.
(no reason not to go ahead and merge this one though).

@mborland
Copy link
Member Author

mborland commented Aug 4, 2022

The failure is unconnected but worrying (GCC-9 and gun++11 mode):

testing.capture-output ../../../bin.v2/libs/math/test/test_chatterjee_correlation.test/gcc-9/debug/link-static/threading-multi/visibility-hidden/test_chatterjee_correlation.run

====== BEGIN OUTPUT ======

Error at test_chatterjee_correlation.cpp:test_paper:130:

  Mollified relative error in float precision is 0.0561, which exceeds 0.012, error/tol  = 4.68.

  Expected: +0.828877568 = +0x1.a862a4p-1

  Computed: +0.884999990 = +0x1.c51eb8p-1

  ULP distance: +941578

malloc(): invalid next size (unsorted)

Aborted (core dumped)

I think that test can be safely removed from CI testing. I'll look at it this week and open a PR for it.

@mborland mborland merged commit 462497a into boostorg:develop Aug 4, 2022
@mborland mborland deleted the issue_810 branch August 4, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with hypergeometric_pFq from mailing list
2 participants