Improving DE performance Part 2 #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix up one failing test.
Recent changes to tanh_sinh alters the order in which values are summed: this can randomly change the found error for either better or worse, and so the 1eps tolerance here was over-optimistic.
This removes insignificant values at either end of the integral by way of a performance improvement. Remove the check within the inner loop for possible early exit as we have already removed the range of values which are likely to be insignificant in value during the first 2 passes.
Fixed Conflicts: include/boost/math/quadrature/detail/exp_sinh_detail.hpp
|
Failed test was a git clone failure in drone, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #706