Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct test for cpp_dec_float division. #712

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

jzmaddock
Copy link
Collaborator

@ckormanyos , @mborland : this should fix the current quaternion / cpp_dec_float failures.

@ckormanyos
Copy link
Member

ckormanyos commented Oct 24, 2021

this should fix the current quaternion / cpp_dec_float failures.

Also note that this recent Multiprecision PR also fixes these tests without disabling them for cpp_dec_float. That Multiprecision PR, however, only partially addresses the missing rounding issue in cpp_dec_float.

We could consider reviving Multiprecision's PR, synchronizing develop's new standalone changes into it and going forward with that PR. It did pass CI. On the other hand, I did list several reservations that I have about only partially addressing the rounding issue. These are in my final post in that PR.

I could be happy with either: go forward with Math's PR here that disables the tests, or move forward on Multiprecision's PR.

See also the relevant comments

Cc: @jzmaddock and @mborland

@jzmaddock
Copy link
Collaborator Author

@ckormanyos I'm easy either way, for now I really just want CI clean again so we can better see where we are ;)

@jzmaddock jzmaddock merged commit 5b61efb into develop Oct 24, 2021
@ckormanyos
Copy link
Member

ckormanyos commented Oct 24, 2021

@ckormanyos I'm easy either way, for now I really just want CI clean again so we can better see where we are

Indeed @jzmaddock. Let's go that way since there has really been a lot going on.

Maybe we can pick up rounding with a more strong effort in 1.79 or 1.80, as I could not fully figure out how to do it by myself. So for the moment, I'm just happy if everything works. I will let the multiprecision PR ripen, maybe synchronize with develop so as not to get too far behind.

@NAThompson NAThompson deleted the quaternion_cpp_dec_float_fix branch October 24, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants