Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constexpr isfinite and isnormal #674

Merged
merged 6 commits into from
Aug 24, 2021

Conversation

mborland
Copy link
Member

No description provided.

@mborland
Copy link
Member Author

@NAThompson and @jzmaddock This should be good for review. The only CI failure is from naive_monte_carlo_test:

====== BEGIN OUTPUT ======
Running 1 test case...
Default hardware concurrency = 2
terminate called after throwing an instance of 'std::domain_error'
  what():  You have done something wrong.

Testing that a reasonable action is performed by the Monte-Carlo integrator when the integrand throws an exception on type float
unknown location(0): fatal error: in "naive_monte_carlo_test": signal: SIGABRT (application abort requested)
naive_monte_carlo_test.cpp(451): last checkpoint: "naive_monte_carlo_test" test entry

*** 1 failure is detected in the test module "naive_monte_carlo_test"

EXIT STATUS: 201
====== END OUTPUT ======

I thought that error had been fixed since I haven't seen it in quite a while now.

@NAThompson
Copy link
Collaborator

NAThompson commented Aug 23, 2021

I just read that error message, thinking "wow, that is the least helpful error message in the universe".

And I realized only I would right something like that.

@NAThompson
Copy link
Collaborator

NAThompson commented Aug 23, 2021

I'm happy with this code, BTW.

If @jzmaddock doesn't have time to look at it I'll merge it.

@NAThompson NAThompson merged commit a4d5ae7 into boostorg:develop Aug 24, 2021
@mborland mborland deleted the constexpr_isfinite branch August 24, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants