parse_into clears strings before filling them

boostorg · Oct 9, 2023 · e19edde · e19edde
1 parent 75981e7
commit e19edde
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/include/boost/json/detail/parse_into.hpp b/include/boost/json/detail/parse_into.hpp
@@ -365,6 +365,7 @@ class converting_handler<string_like_conversion_tag, V, P>
 {
 private:
     V* value_;
+    bool cleared_ = false;
 
 public:
     converting_handler( V* v, P* p )
@@ -374,12 +375,23 @@ class converting_handler<string_like_conversion_tag, V, P>
 
     bool on_string_part( error_code&, string_view sv )
     {
+        if( !cleared_ )
+        {
+            cleared_ = true;
+            value_->clear();
+        }
+
         value_->append( sv.begin(), sv.end() );
         return true;
     }
 
     bool on_string( error_code&, string_view sv )
     {
+        if( !cleared_ )
+            value_->clear();
+        else
+            cleared_ = false;
+
         value_->append( sv.begin(), sv.end() );
 
         this->parent_->signal_value();

diff --git a/test/parse_into.cpp b/test/parse_into.cpp
@@ -214,6 +214,13 @@ class parse_into_test
         testParseInto<std::string>( "12345" );
 
         testParseIntoErrors< string >( error::not_string, UINT64_MAX );
+
+        std::string s;
+        parse_into(s, R"( "foobar" )");
+        BOOST_TEST( s.size() == 6 );
+
+        parse_into(s, R"( "qwertyuiop" )");
+        BOOST_TEST( s.size() == 10 );
     }
 
     void testSequence()