Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune up GHA matrix #244

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Tune up GHA matrix #244

merged 1 commit into from
Nov 27, 2024

Conversation

jeking3
Copy link
Collaborator

@jeking3 jeking3 commented Nov 27, 2024

  • Add macos-15
  • Move gcc-10+ to 22.04
  • Move coverage from gcc-8 to gcc-13 and build with cxxstd 03,2b
  • Move coverity to clang-12 and build with cxxstd 03,20
  • Remove ubuntu-24.04 container, use 24.04 runner
  • Remove redundant libc++ clang-12 build

I recently used these changes in dynamic_bitset.

@jeking3 jeking3 requested a review from Flamefire November 27, 2024 14:06
@jeking3
Copy link
Collaborator Author

jeking3 commented Nov 27, 2024

Hmm, since the build rules kick off a build for the push and for the CI, I canceled the push jobs. Those will appear skipped. This is because I named the branch as something that builds on commit, and I canceled the "push" actions job, leaving just the PR one.

@jeking3
Copy link
Collaborator Author

jeking3 commented Nov 27, 2024

Interesting: moving clang-17 to use cxxstd=23 instead of cxxstd=2b caused a build failure.

@Flamefire
Copy link
Collaborator

Interesting: moving clang-17 to use cxxstd=23 instead of cxxstd=2b caused a build failure.

Odd indeed.

BTW: When intending to open a PR here consider renaming the branch first to something that doesn't trigger a build. fix/* is a pattern that triggers a build of the branch causing duplicate builds.

- Add macos-15
- Move gcc-10+ to 22.04
- Move coverage from gcc-8 to gcc-13 and build with cxxstd 03,2b
- Move coverity to clang-12 and build with cxxstd 03,20
- Remove ubuntu-24.04 container, use 24.04 runner
- Remove redundant libc++ clang-12 build
- Deal with clang-17 incompatibility with libstdc++-13 with cxxstd 2b/23
@jeking3
Copy link
Collaborator Author

jeking3 commented Nov 27, 2024

Agreed, but too late for this series. I've just been canceling the push commit for now.

clang-17 is not compatible with libstdc++-13 from gcc in 2b/23 mode.
llvm/llvm-project#59827
I disabled building 2b/23 on clang-17 on 24.04 as it's not a libc++ test.

It was previously using a container, which was likely causing it to be a libc++ build and test, which was not the intention of that entry. Now that we're not using the container, it exposed this issue.

@Flamefire
Copy link
Collaborator

All good, GHA passed, won't wait for the other 2.

@Flamefire Flamefire merged commit 8ea98f7 into master Nov 27, 2024
48 of 94 checks passed
@Flamefire Flamefire deleted the fix/gha-tuneup branch November 27, 2024 18:51
@Flamefire
Copy link
Collaborator

@jeking3

I tested a coverage job with GCC 13 instead of 8 with everything else equal and got quite a few changes in coverage:

  Lines        10353    10665     +312     
  + Hits          9920    10188     +268     
- Misses         433      477      +44     

One such change is a new, uncovered closing brace: https://app.codecov.io/gh/boostorg/nowide/pull/190/blob/include/boost/nowide/utf/convert.hpp#L91

That is even without branch coverage. Do you see such issues too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants