-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune up GHA matrix #244
Tune up GHA matrix #244
Conversation
70bd194
to
6a64e2f
Compare
Hmm, since the build rules kick off a build for the push and for the CI, I canceled the push jobs. Those will appear skipped. This is because I named the branch as something that builds on commit, and I canceled the "push" actions job, leaving just the PR one. |
6a64e2f
to
e1387d8
Compare
e1387d8
to
7ef6c58
Compare
Interesting: moving clang-17 to use cxxstd=23 instead of cxxstd=2b caused a build failure. |
Odd indeed. BTW: When intending to open a PR here consider renaming the branch first to something that doesn't trigger a build. |
- Add macos-15 - Move gcc-10+ to 22.04 - Move coverage from gcc-8 to gcc-13 and build with cxxstd 03,2b - Move coverity to clang-12 and build with cxxstd 03,20 - Remove ubuntu-24.04 container, use 24.04 runner - Remove redundant libc++ clang-12 build - Deal with clang-17 incompatibility with libstdc++-13 with cxxstd 2b/23
7ef6c58
to
2be7633
Compare
Agreed, but too late for this series. I've just been canceling the push commit for now. clang-17 is not compatible with libstdc++-13 from gcc in 2b/23 mode. It was previously using a container, which was likely causing it to be a libc++ build and test, which was not the intention of that entry. Now that we're not using the container, it exposed this issue. |
All good, GHA passed, won't wait for the other 2. |
I tested a coverage job with GCC 13 instead of 8 with everything else equal and got quite a few changes in coverage:
One such change is a new, uncovered closing brace: https://app.codecov.io/gh/boostorg/nowide/pull/190/blob/include/boost/nowide/utf/convert.hpp#L91 That is even without branch coverage. Do you see such issues too? |
I recently used these changes in dynamic_bitset.