Application controller doesn't expose "no chart version found" problem

[osdrv]

A chart version resolve problem must be surfaced and visible to end users.

Example of the problem:

E0829 12:28:51.316030    4651 application_controller.go:170] error syncing Application "olegs-test/testapp-v1alpha1" (
will retry: true): failed to resolve chart version [name: "nginx", version: "1.0.2", repo: "http://0.0.0.0:8879"]: no
chart version found

Application object:

{
    "apiVersion": "shipper.booking.com/v1alpha1",
    "kind": "Application",
    "metadata": {
        "annotations": {
            "kubectl.kubernetes.io/last-applied-configuration": "{\"apiVersion\":\"shipper.booking.com/v1alpha1\",\"kind\":\"Application\",\"metadata\":{\"annotations\":{},\"labels\":{\"foo\":\"bar\"},\"name\":\"testapp-v1alpha1\",\"namespace\":\"olegs-test\"},\"spec\":{\"revisionHistoryLimit\":10,\"template\":{\"chart\":{\"name\":\"nginx\",\"repoUrl\":\"http://0.0.0.0:8879\",\"version\":\"1.0.2\"},\"clusterRequirements\":{\"capabilities\":[],\"regions\":[{\"name\":\"local\"}]},\"strategy\":{\"steps\":[{\"capacity\":{\"contender\":1,\"incumbent\":100},\"name\":\"staging\",\"traffic\":{\"contender\":0,\"incumbent\":100}},{\"capacity\":{\"contender\":50,\"incumbent\":50},\"name\":\"50/50\",\"traffic\":{\"contender\":50,\"incumbent\":50}},{\"capacity\":{\"contender\":100,\"incumbent\":0},\"name\":\"full on\",\"traffic\":{\"contender\":100,\"incumbent\":0}}]},\"values\":{\"replicaCount\":4,\"time\":\"__TIME__\"}}}}\n"
        },
        "creationTimestamp": "2019-08-29T10:26:18Z",
        "generation": 1,
        "labels": {
            "foo": "bar"
        },
        "name": "testapp-v1alpha1",
        "namespace": "olegs-test",
        "resourceVersion": "22470079",
        "selfLink": "/apis/shipper.booking.com/v1alpha1/namespaces/olegs-test/applications/testapp-v1alpha1",
        "uid": "955bff46-c856-4aad-b8c0-e8890b197798"
    },
    "spec": {
        "revisionHistoryLimit": 10,
        "template": {
            "chart": {
                "name": "nginx",
                "repoUrl": "http://0.0.0.0:8879",
                "version": "1.0.2"
            },
            "clusterRequirements": {
                "capabilities": [],
                "regions": [
                    {
                        "name": "local"
                    }
                ]
            },
            "strategy": {
                "steps": [
                    {
                        "capacity": {
                            "contender": 1,
                            "incumbent": 100
                        },
                        "name": "staging",
                        "traffic": {
                            "contender": 0,
                            "incumbent": 100
                        }
                    },
                    {
                        "capacity": {
                            "contender": 50,
                            "incumbent": 50
                        },
                        "name": "50/50",
                        "traffic": {
                            "contender": 50,
                            "incumbent": 50
                        }
                    },
                    {
                        "capacity": {
                            "contender": 100,
                            "incumbent": 0
                        },
                        "name": "full on",
                        "traffic": {
                            "contender": 100,
                            "incumbent": 0
                        }
                    }
                ]
            },
            "values": {
                "replicaCount": 4,
                "time": "__TIME__"
            }
        }
    }
}

Expected behavior: Application object contains some hints about the problem.

[Shubhamchinda]

Hey, Can I take this up?

[osdrv]

@Shubhamchinda sure, go for it! :-)

[osdrv]

@Shubhamchinda hey, howdy! It seems this issue is planned to end up in 0.6 and the first release of this branch is now scheduled on Sep 16. Do you think there is a chance you can finish this task until this moment? Thanks!

[osdrv]

Fixed in #179