Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove action notify-slack #124

Merged
merged 3 commits into from
Apr 15, 2024
Merged

refactor!: remove action notify-slack #124

merged 3 commits into from
Apr 15, 2024

Conversation

akantcheff
Copy link
Contributor

The action have been moved to a dedicated repository https://github.com/bonitasoft/notify-slack-action

@akantcheff akantcheff changed the title tr(notify-slack): remove action notify-slack ci(notify-slack): remove action notify-slack Feb 16, 2024
@akantcheff
Copy link
Contributor Author

⚠️ Wait before merging for exisiting github actions to use the new one

@tbouffard
Copy link
Member

IHMO, we can merge this PR
The workflows in the bonitasoft organization that uses this action are always using it by targeting a tag, so they won't be impacted by a change in the main branch.
Currently, we have other breaking changes in the pipe like #125, so we could group them all in a new major v3 version.

@tbouffard tbouffard changed the title ci(notify-slack): remove action notify-slack refactor!: remove action notify-slack Apr 15, 2024
@tbouffard tbouffard added the chore Something about the build label Apr 15, 2024
@tbouffard tbouffard marked this pull request as ready for review April 15, 2024 09:30
tbouffard
tbouffard approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminParisel benjaminParisel merged commit 92a7c23 into main Apr 15, 2024
1 check passed
@benjaminParisel benjaminParisel deleted the tr/remove-notify-slack branch April 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@benjaminParisel benjaminParisel Awaiting requested review from benjaminParisel

Assignees
No one assigned
Labels
chore Something about the build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akantcheff @tbouffard @benjaminParisel