Skip to content

Commit

Permalink
Create a gasnet-ex shim
Browse files Browse the repository at this point in the history
Create a gasnet-ex shim that we can use to upgrade to the gasnet-ex API.
Today we use the gasnet-ex source, but the gasnet-1 API. We want to
start upgrading to the new API, but don't want to disrupt production
usage. To enable this, add a `CHPL_GASNET_VERSION` chplenv that can
either be `1` (the default) or `ex`. When `ex`, this will trigger using
the new `comm-gasnet-ex.c` source. Currently that's just a straight
clone, but we'll update over time. Note that `CHPL_GASNET_VERSION` is
part of the unique build path, so we can have gasnet-1 and gasnet-ex
builds in the same tree.

I considered doing this as a `CHPL_COMM=gasnet-ex`, but we have a lot of
things that check for `CHPL_COMM==gasnet` and it didn't feel worth the
time to track all those down and copy more of the runtime build
infrastructure.

Part of 14443

Signed-off-by: Elliot Ronaghan <[email protected]>
  • Loading branch information
ronawho committed Aug 22, 2023
1 parent f207a2a commit 2f4776e
Show file tree
Hide file tree
Showing 5 changed files with 1,654 additions and 1 deletion.
7 changes: 6 additions & 1 deletion runtime/src/comm/gasnet/Makefile.share
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,14 @@ COMM_LAUNCHER_SRCS = \
comm-gasnet-locales.c \

COMM_SRCS = \
comm-gasnet.c \
comm-gasnet-locales.c \

ifeq ($(CHPL_MAKE_GASNET_VERSION),ex)
COMM_SRCS += comm-gasnet-ex.c
else
COMM_SRCS += comm-gasnet.c
endif

SRCS = \
comm-gasnet.c \
comm-gasnet-launch.c \
Expand Down
Loading

0 comments on commit 2f4776e

Please sign in to comment.