This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Add madvise() after mmap(). #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit advises the mmapped data file to use MADV_RANDOM to avoid readahead. This can provide a performance boost to Bolt databases that are larger than memory by avoiding unnecessary disk i/o.
Have you got a benchmark? |
|
I don't have specific benchmark details that I can show but in production our disk latency went down by 80% and the number of pages being paged in & out dropped by about 90%. |
benbjohnson
added a commit
that referenced
this pull request
Jun 3, 2015
Add madvise() after mmap().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request advises the memory-mapped data file to use
MADV_RANDOMto avoid readahead. This can provide a performance boost to Bolt databases that are larger than memory by avoiding unnecessary disk I/O.