This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Implement io.WriterTo interface on Tx. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 How about updating |
This commit moves the functionality in Tx.Copy() to Tx.WriteTo(). This allows Tx to be used as an io.WriterTo which makes it easier to mock. The Tx.Copy() function still exists but it's simply a wrapper around Tx.WriteTo().
benbjohnson
force-pushed
the
tx-writer-to
branch
from
bd61289 to
8c6af54
Compare
|
Good catch! I updated the docs in 8c6af54. |
benbjohnson
added a commit
that referenced
this pull request
Mar 22, 2015
Implement io.WriterTo interface on Tx.
| @@ -343,7 +343,8 @@ func BackupHandleFunc(w http.ResponseWriter, req *http.Request) { | |||
| w.Header().Set("Content-Type", "application/octet-stream") | |||
| w.Header().Set("Content-Disposition", `attachment; filename="my.db"`) | |||
| w.Header().Set("Content-Length", strconv.Itoa(int(tx.Size()))) | |||
| return tx.Copy(w) | |||
| _, err := tx.WriteTo(w) | |||
| return err | |||
There was a problem hiding this comment.
What's the benefit of writing 2 lines to use tx.WriteTo instead of the original 1 line with tx.Copy?
There was a problem hiding this comment.
There's no benefit, necessarily. I mainly like to stick with the stdlib interfaces where possible.
There was a problem hiding this comment.
👍 thanks for answering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request moves the functionality in
Tx.Copy()toTx.WriteTo(). This allowsTxto be used as anio.WriterTowhich makes it easier to mock.The
Tx.Copy()function still exists but it's simply a wrapper aroundTx.WriteTo().