Fixed: Files without recognised extensions don't break the file browser. #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobdenotter
changed the title
bobdenotter
changed the title
|
One thing though, it's not really deprecated anymore than the class itself is. Maybe remove that comment? |
|
Should I then just omit the comment there? It might be good to keep a reference to the issue number in, right? |
|
Sure, if you want. I don't think it's necessary. It was really just an oversight before. |
|
Updated the comment. |
|
Added explaination to that issue too |
|
Really the line above it for |
|
I'm a bit wary to remove that one. Afraid it'll come back to haunt us in unexpected ways. :-) |
|
Ok no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5759, until a better solution lands.