Add HTTP User Detail extension #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesdejager
force-pushed
the
hannes/usrdetail-http
branch
4 times, most recently
from
7233987 to
ccc48f1
Compare
hannesdejager
force-pushed
the
hannes/usrdetail-http
branch
from
ccc48f1 to
8a59671
Compare
hannesdejager
force-pushed
the
hannes/usrdetail-http
branch
from
8a59671 to
9edb933
Compare
robklg
approved these changes
May 19, 2024
This adds functionality to unFTP that allows unFTP to obtain user detail over HTTP in addition to the already existing JSON file. It uses the extact same format as the JSON file functionality. The 'usr-http-url' command line arguments activate this feature. You pass it a base URL, unFTP appends a username to it and performs a GET request to the URL. The HTTP server should respond with a 200 OK and JSON body containing an array of users which should at least contain the requested user's details. Later on we can support diffent HTTP verbs and sending the username via an HTTP header instead of the URL path or Post body. For now I'm just keeping it simple.
hannesdejager
force-pushed
the
hannes/usrdetail-http
branch
from
9edb933 to
62187ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to unFTP that allows unFTP to obtain user
detail over HTTP in addition to the already existing JSON file.
It uses the extact same format as the JSON file functionality. The
'usr-http-url' command line arguments activate this feature. You
pass it a base URL, unFTP appends a username to it and performs
a GET request to the URL. The HTTP server should respond with a
200 OK and JSON body containing an array of users which should
at least contain the requested user's details.
Later on we can support diffent HTTP verbs and sending the
username via an HTTP header instead of the URL path or Post
body. For now I'm just keeping it simple.