Make RangeTool respect Range.{min,max}_interval
#13561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
force-pushed
the
mattpap/13483_respect_max_interval
branch
from
07cfeb0 to
c868b58
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13561 +/- ##
===========================================
Coverage 92.57% 92.58%
===========================================
Files 323 323
Lines 20525 20530 +5
===========================================
+ Hits 19002 19007 +5
Misses 1523 1523 |
mattpap
force-pushed
the
mattpap/13483_respect_max_interval
branch
from
c868b58 to
1e763fe
Compare
mattpap
force-pushed
the
mattpap/13483_respect_max_interval
branch
from
1e763fe to
3006e9f
Compare
philippjfr
reviewed
Jan 23, 2024
mattpap
force-pushed
the
mattpap/13483_respect_max_interval
branch
from
3006e9f to
43e7883
Compare
mattpap
force-pushed
the
mattpap/13483_respect_max_interval
branch
from
43e7883 to
2a05459
Compare
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Make RangeTool respect Range.{min,max}_interval
* Replace custom code with View.on_transitive_change()
* Add visual integration tests
* Simplify usage of View.on_transitive_change()
* Update unit tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
RangeToolrespect itsx_rangeandy_rangelimits. Also adds support for{min,max}_{width,height}constraints toBoxAnnotation. These constraints work, but overall the support is cumbersome in edge cases and will require additional work in a future PR, to polish the behavior. This PR also addsView.on_transitive_changefor connectingchangesignals of transitive models in a view. I originally added this in PR #13538, but it's useful here as well and harder to miss in a much smaller PR. This approach is generic enough to later be used in all other context where previously we either had custom code or no signal reconnect/cleanup at all.fixes #13483