-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for basic measurement tools #13279
Open
mattpap
wants to merge
1
commit into
branch-3.7
Choose a base branch
from
mattpap/182_measurement_tools
base: branch-3.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13279 +/- ##
==============================================
- Coverage 92.65% 92.63% -0.02%
==============================================
Files 326 323 -3
Lines 20736 20640 -96
==============================================
- Hits 19212 19120 -92
+ Misses 1524 1520 -4 |
Fixes issue #182, opened ten years ago!!! |
mattpap
force-pushed
the
mattpap/182_measurement_tools
branch
from
October 15, 2023 09:01
41251e3
to
dc840ef
Compare
mattpap
force-pushed
the
mattpap/182_measurement_tools
branch
from
November 18, 2023 01:13
dc840ef
to
60d259c
Compare
mattpap
force-pushed
the
mattpap/182_measurement_tools
branch
4 times, most recently
from
December 6, 2023 20:12
acd8260
to
276c4d0
Compare
mattpap
force-pushed
the
mattpap/182_measurement_tools
branch
2 times, most recently
from
April 9, 2024 15:51
cd63514
to
9c98436
Compare
mattpap
force-pushed
the
mattpap/182_measurement_tools
branch
from
January 19, 2025 21:38
9c98436
to
19deb8e
Compare
mattpap
force-pushed
the
mattpap/182_measurement_tools
branch
from
January 20, 2025 09:13
19deb8e
to
e43ce65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early prototype. The main goals of this PR are the following:
x_units
etc. anymore).Measurement tools in this PR are a side effect and a practical way of showing those working.
fixes #182
Example: