Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS credential options #56

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Fix TLS credential options #56

merged 4 commits into from
Jan 23, 2019

Conversation

bojand
Copy link
Owner

@bojand bojand commented Jan 23, 2019

Should address #55.

All security related options:

-cacert		File containing trusted root certificates for verifying the server.
-cert		File containing client certificate (public key), to present to the server. Must also provide -key option.
-key 		File containing client private key, to present to the server. Must also provide -cert option.
-cname		Server name override when validating TLS certificate - useful for self signed certs.
-skipTLS	Skip TLS client verification of the server's certificate chain and host name.
-insecure	Use plaintext and insecure connection.
-authority	Value to be used as the :authority pseudo-header. Only works if -insecure is used.

Breaking API changes with regards to WithCertificate().
Adds new API functions for additional options.

Copy link

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you. 🎈

@bojand bojand merged commit 3f7e9ee into master Jan 23, 2019
@bojand bojand deleted the tls_fix branch October 23, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants