Exposes runner.NewRequester publicly #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyl-stripe
changed the title
|
Hello, thanks for the PR! It's been released in v0.60.0. You should be able to update the dependency using go get -u github.com/bojand/[email protected]I will keep #223 open for now as I do believe perhaps longer term having a cancel channel config option may be a useful way to allow for this as well, without clients having to mess with the requestor instance. Wanted to get this unblocked until I can get to that change. Thanks again, feel free to open any issues if they come up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #223 this PR adds the ability to create a
runner.Requesterwithout having to callrunner.Runwhich has the issue that it blocks when called.Being able to create and have direct access to the
runner.Requestermeans that a user can setup differing ways of canceling runs beyond what is possible withrunner.Runas they will have direct access torunner.Requester.Stop(...).A potential alternative to this is exposing a new option that takes a channel that can be used to listen for a cancel signal, although that seems like a bit more complicated approach than this.