Report details fix #109
Merged
Report details fix #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojand
reviewed
Jul 5, 2019
|
Hello, thank you for the PR! I see the issue 🤦♂ and this is a good catch. I like the code changes. I made minor code style change. This has been released as 0.39.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working further with ghz I observed strange values in the csv report.
There are four fields in the report: Timestamp, Latency, Status and Error. The problem is that sometimes latency doesn't correspond to status. F.e., I have a row with DeadlineExceeded status, but latency (350 ms) is still inside specified client timeout (500ms) which makes no sense.
It turns out there's a bug in the reporter. If there're errors during the test they are not counted in
latsarray. However, both errors and oks are recorded instatusesarray. So, the index inlatsdoesn't always correspond to the index in other stat arrays.This PR fixes the problem. Details array is recorded right away during background report processing. Then filtering is used to compute percentiles of successful requests.