Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for gRPC with XDS #293

Closed
stevenctl opened this issue Jul 15, 2021 · 1 comment
Closed

Support for gRPC with XDS #293

stevenctl opened this issue Jul 15, 2021 · 1 comment

Comments

@stevenctl
Copy link

Is your feature request related to a problem? Please describe.

Testing with XDS resolver enabled would be very useful, especially when trying to compare:

  • Plain gRPC
  • gRPC with some proxy in front of it (e.g. Envoy, Linkerd proxy, etc)
  • gRPC with XDS resolver enabled/TLS configs etc.

Describe the solution you'd like

Simply performing the side-effect import will allow xds:/// scheme to be used (assuming the user has the proper env variables for GRPC_XDS_BOOTSTRAP) set.

Additional context

gRPC has added support for configuration via XDS: https://github.com/grpc/proposal/blob/master/A27-xds-global-load-balancing.md

To use it as a client in Go, we simply need to add the following side-effect import:

// To install the xds resolvers and balancers. 
_ "google.golang.org/grpc/xds"

This just registers the builder, but doesn't do anything unless a bootstrap file is provided.

bojand added a commit that referenced this issue Aug 13, 2021
Add support for gRPC with XDS. Addresses #293.
@bojand
Copy link
Owner

bojand commented Aug 13, 2021

Hello I think this is addressed via #300 and should be available in 0.100.0. Feel free to reopen the issue if there are problems.

@bojand bojand closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants