Error logs mangle return error message

[tp]

Describe the bug
We have an error message that includes an encoded URLs. In ghz that seems to be used in a format string and hence leading to this output:

Error distribution:
  [20000]   rpc error: code = Unknown desc = Non-success status code 401 for https://host.com/api/outfits/v1?appId=10&outfitIds%!B(MISSING)%!D(MISSING)%!B(MISSING)%!D(MISSING)=10569&outfitIds%!B(MISSING)%!D(MISSING)%!B(MISSING)%!D(MISSING)=10570&outfitIds%!B(MISSING)%!D(MISSING)%!B(MISSING)%!D(MISSING)=10568&outfitIds%!B(MISSING)%!D(MISSING)%!B(MISSING)%!D(MISSING)=10561&outfitIds%!B(MISSING)%!D(MISSING)%!B(MISSING)%!D(MISSING)=10564&outfitIds%!B(MISSING)%!D(MISSING)%!B(MISSING)%!D(MISS

To Reproduce

Return an error message with % in it

Expected behavior

Should log the error message verbatim

Environment

• OS: 10.14.6
• ghz: 0.41.0

Screenshots

In BloomRPC for example the response looks just fine:

Additional context
Add any other context about the problem here.

[tp]

I had a quick look into this codebase but couldn't easily spot the file that prints this.

Looks pretty clear what kind of string build / formatting would cause this, if you can point me into the right direction I can have a stab at fixing the issue as well.

[bojand]

Hmm that's not very useful. It might be something to do with how we print errors using the default template. I will try and take a look soon when I get a bit more time.

[tp]

@bojand Isn't is just this line: https://github.com/bojand/ghz/blob/master/printer/printer.go#L46 ?

return rp.printf(buf.String())

I guess if you change that from printf to print it will be fine. Should not change anything, as there are no parameters anyway.