Skip to content

Commit

Permalink
Swallow RPC errors as they are handled by stats handler and reported …
Browse files Browse the repository at this point in the history
…in reports
  • Loading branch information
bojand committed Feb 24, 2019
1 parent 645ad20 commit 7cd212e
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions runner/requester.go
Original file line number Diff line number Diff line change
Expand Up @@ -326,17 +326,20 @@ func (b *Requester) makeRequest() error {
ctx = metadata.NewOutgoingContext(ctx, *reqMD)
}

// RPC errors are handled via stats handler

if b.mtd.IsClientStreaming() && b.mtd.IsServerStreaming() {
return b.makeBidiRequest(&ctx, streamInput)
_ = b.makeBidiRequest(&ctx, streamInput)
}
if b.mtd.IsClientStreaming() {
return b.makeClientStreamingRequest(&ctx, streamInput)
_ = b.makeClientStreamingRequest(&ctx, streamInput)
}
if b.mtd.IsServerStreaming() {
return b.makeServerStreamingRequest(&ctx, input)
_ = b.makeServerStreamingRequest(&ctx, input)
}

// TODO: handle response?
_, err = b.stub.InvokeRpc(ctx, b.mtd, input)
_, _ = b.stub.InvokeRpc(ctx, b.mtd, input)
return err
}

Expand Down

0 comments on commit 7cd212e

Please sign in to comment.