Skip to content

Commit

Permalink
Remove deprecated receivertest.NewNopFactoryForType (open-telemetry#1…
Browse files Browse the repository at this point in the history
…2110)

Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu authored Jan 17, 2025
1 parent bdf3ce4 commit e970f8b
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 19 deletions.
25 changes: 25 additions & 0 deletions .chloggen/rm-dep-receivertest.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: receivertest

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove deprecated receivertest.NewNopFactoryForType

# One or more tracking issues or pull requests related to the change
issues: [12110]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
19 changes: 0 additions & 19 deletions receiver/receivertest/nop_receiver.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/consumer/xconsumer"
"go.opentelemetry.io/collector/pipeline"
"go.opentelemetry.io/collector/receiver"
"go.opentelemetry.io/collector/receiver/xreceiver"
)
Expand Down Expand Up @@ -40,24 +39,6 @@ func NewNopFactory() receiver.Factory {
)
}

// Deprecated: [v0.117.0] use NewNopFactory or create own factory.
func NewNopFactoryForType(signal pipeline.Signal) receiver.Factory {
var factoryOpt receiver.FactoryOption
switch signal {
case pipeline.SignalTraces:
factoryOpt = receiver.WithTraces(createTraces, component.StabilityLevelStable)
case pipeline.SignalMetrics:
factoryOpt = receiver.WithMetrics(createMetrics, component.StabilityLevelStable)
case pipeline.SignalLogs:
factoryOpt = receiver.WithLogs(createLogs, component.StabilityLevelStable)
default:
panic("unsupported data type for creating nop receiver factory: " + signal.String())
}

componentType := component.MustNewType(defaultComponentType.String() + "_" + signal.String())
return receiver.NewFactory(componentType, func() component.Config { return &nopConfig{} }, factoryOpt)
}

type nopConfig struct{}

func createTraces(context.Context, receiver.Settings, component.Config, consumer.Traces) (receiver.Traces, error) {
Expand Down

0 comments on commit e970f8b

Please sign in to comment.