Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head to BD #158

Merged
merged 95 commits into from
Oct 23, 2017
Merged

Head to BD #158

merged 95 commits into from
Oct 23, 2017

Conversation

bogdan-tanygin
Copy link
Owner

Fixes #

Description of changes:

PR Checklist

  • Tests?
    • Interface
    • Core
  • Docs?

fweik and others added 30 commits June 1, 2017 18:20
independent of the cell system. New function short_range_loop
that ties together Espresso globals (skin...) and cell system
specific distance calculation, and runs caller-supplied kernels
on the pairs. Addapted icc, energy, force and pressure calculation to
use these new functions. Tests for link_cell and verler_ia.
Sorry for the monolithic commit.
Up to values of 1E-3, approximately.
finalize() and get_datata()
This may well have been the Heisenbug causing the segfaults
Remove correlators from system.auto_update_correlators after finalize() call
energy and momenum conservation for non-isotropi itensor
@codecov-io
Copy link

codecov-io commented Oct 21, 2017

Codecov Report

Merging #158 into bd will increase coverage by 1.51%.
The diff coverage is 73.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##               bd     #158      +/-   ##
==========================================
+ Coverage   42.04%   43.55%   +1.51%     
==========================================
  Files         356      361       +5     
  Lines       29758    28134    -1624     
  Branches     5401     5308      -93     
==========================================
- Hits        12512    12255     -257     
+ Misses      17220    15855    -1365     
+ Partials       26       24       -2
Impacted Files Coverage Δ
src/core/grid.cpp 54.8% <ø> (+0.17%) ⬆️
src/core/lb.cpp 61.37% <ø> (+1.79%) ⬆️
src/core/unit_tests/mock/Cell.hpp 100% <ø> (ø) ⬆️
src/core/unit_tests/ParticleIterator_test.cpp 100% <ø> (+1.66%) ⬆️
src/core/unit_tests/mock/Particle.hpp 100% <ø> (ø) ⬆️
src/core/utils.hpp 31.64% <ø> (-2.46%) ⬇️
src/core/rotation.cpp 83.61% <ø> (-0.04%) ⬇️
src/core/integrate.cpp 49.86% <ø> (+2.01%) ⬆️
src/core/virtual_sites_com.cpp 2.43% <ø> (+0.03%) ⬆️
src/core/communication.cpp 57.56% <ø> (-0.42%) ⬇️
... and 226 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4310a0e...bd78b48. Read the comment docs.

@bogdan-tanygin bogdan-tanygin merged commit 797255c into bogdan-tanygin:bd Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants