Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.3 #186

Open
wants to merge 2 commits into
base: 1.5.x
Choose a base branch
from
Open

Add support for PHP 8.3 #186

wants to merge 2 commits into from

Conversation

boesing
Copy link
Owner

@boesing boesing commented Oct 10, 2023

No description provided.

@boesing boesing added the enhancement New feature or request label Oct 10, 2023
@boesing boesing added this to the 1.5.0 milestone Oct 10, 2023
Signed-off-by: Maximilian Bösing <[email protected]>
@andrey-tech
Copy link

@boesing Hello! I hope all is well with you.
Do you plan to add PHP 8.3 support in the near future? Now I have upgraded the PHP version in my projects from 8.2 to 8.3 and would like to continue using your great Psalm plugin with new PHP version.

@boesing
Copy link
Owner Author

boesing commented Sep 30, 2024

hey @andrey-tech, most probably not. the reason is that if u are on 8.3 u are also most probably on a psalm version which changed the way of handling sprintf type handling in this plugin.

Thus said, this plugin is not able to provide its purpose with more recent psalm versions due to internal changes of psalm.

I will see if I can find the psalm issue Ive created related to this problem. The suggestion was that I could implement my plugin in psalm directly. Since I am not using psalm in my current role, I do not see me doing that. Since my Code is not secret, this plugin can work as a starting point for this kind of work but this plugin is literally not providing any benefit as of today (maybe for scanf but that was not the main intention).

@boesing
Copy link
Owner Author

boesing commented Sep 30, 2024

Here you go: vimeo/psalm#10275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants