Update DeleteUser to remove roles first prior to full deletion #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthtrevino
commented
Jan 4, 2022
| @@ -78,6 +80,16 @@ export class DeleteUserInteractor implements Interactor<MutationDeleteUserArgs, | |||
| return new FailedResponse(this.localization.t('mutation.deleteUser.fail')) | |||
| } | |||
|
|
|||
| try { | |||
| } catch (error) { | |||
| return new FailedResponse(this.localization.t('mutation.deleteUser.fail')) | |||
There was a problem hiding this comment.
Why did we decide to revert to using FailedResponse instead of using the Error responses that Apollo provides?
|
When we delete a user, what happens to requests that are assigned to them? |
outofambit
force-pushed
the
fix/delete_user_org
branch
from
2146dc1 to
7194f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.