add callback to log the ERROR status for the error job

[gnarf]

Noticed that there was a possibility of logging the ERROR status in the current app deploy so upgrading the new workflow to have a branch near the end to log ERROR instead of COMPLETED

[jugglinmike]

I've been wondering if we could do something like this! I can't say I'm a fan of how GitHub defines these semantics (specifically, in the absence of a directive named "continue-on-error", I would expect the Workflow to abort on error), but a quick review of the relevant docs suggests that this is indeed how one is supposed to express this logic.

[jugglinmike]

Suggested change

	if: always()
	if: ${{ always() }}

[gnarf]

I actually believe it's preferred to not use the expression syntax for always by itself.

https://github.com/w3c/aria-at-app/pull/961/files#diff-fcc964e27d1e22339051a8ce39304eb2c721e3d96ab72d9fb20b4a2192f74b60R47

I seem to recall reading old issues saying that using the expression syntax with one of these alone was actually causing errors

[gnarf]

Actually - my memory was slightly incorrect, seems you can omit the expression syntax entirely.

https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f#comment112735158_58859404

1390571

https://github.com/bocoup/aria-at-gh-actions-helper/actions/runs/8472751048/job/23215516701 is a test run with no expression braces at all

[jugglinmike]

My preference is for the most consistent syntax even at the expense of verbosity for the same reason I don't lean on ASI when writing JS--honoring the exceptions results in more cognitive load and more risk than I think is warranted. I'm willing to be flexible on a few lines, though.