Add at/browser key to queries for Data Managment and Test Queue

bocoup · May 21, 2024 · a659c83 · a659c83
1 parent 4577543
commit a659c83
Show file tree

Hide file tree

Showing 8 changed files with 107 additions and 3 deletions.
diff --git a/client/components/AddTestToQueueWithConfirmation/index.jsx b/client/components/AddTestToQueueWithConfirmation/index.jsx
@@ -323,8 +323,16 @@ function AddTestToQueueWithConfirmation({
 
 AddTestToQueueWithConfirmation.propTypes = {
     testPlanVersion: PropTypes.object,
-    browser: PropTypes.object,
-    at: PropTypes.object,
+    browser: PropTypes.shape({
+        id: PropTypes.string.isRequired,
+        key: PropTypes.string.isRequired,
+        name: PropTypes.string.isRequired
+    }),
+    at: PropTypes.shape({
+        id: PropTypes.string.isRequired,
+        key: PropTypes.string.isRequired,
+        name: PropTypes.string.isRequired
+    }),
     buttonRef: PropTypes.object,
     onFocus: PropTypes.func,
     onBlur: PropTypes.func,

diff --git a/client/components/DataManagement/queries.js b/client/components/DataManagement/queries.js
@@ -9,9 +9,11 @@ export const DATA_MANAGEMENT_PAGE_QUERY = gql`
         }
         ats {
             id
+            key
             name
             browsers {
                 id
+                key
                 name
             }
             atVersions {
@@ -66,10 +68,12 @@ export const DATA_MANAGEMENT_PAGE_QUERY = gql`
                 markedFinalAt
                 at {
                     id
+                    key
                     name
                 }
                 browser {
                     id
+                    key
                     name
                 }
                 issues {
@@ -135,10 +139,12 @@ export const UPDATE_TEST_PLAN_VERSION_PHASE = gql`
                         id
                         at {
                             id
+                            key
                             name
                         }
                         browser {
                             id
+                            key
                             name
                         }
                         issues {
@@ -182,10 +188,12 @@ export const UPDATE_TEST_PLAN_VERSION_RECOMMENDED_TARGET_DATE = gql`
                         id
                         at {
                             id
+                            key
                             name
                         }
                         browser {
                             id
+                            key
                             name
                         }
                         issues {

diff --git a/client/components/ManageTestQueue/index.jsx b/client/components/ManageTestQueue/index.jsx
@@ -738,7 +738,20 @@ const ManageTestQueue = ({
 };
 
 ManageTestQueue.propTypes = {
-    ats: PropTypes.array,
+    ats: PropTypes.arrayOf(
+        PropTypes.shape({
+            id: PropTypes.string.isRequired,
+            key: PropTypes.string.isRequired,
+            name: PropTypes.string.isRequired,
+            browsers: PropTypes.arrayOf(
+                PropTypes.shape({
+                    id: PropTypes.string.isRequired,
+                    key: PropTypes.string.isRequired,
+                    name: PropTypes.string.isRequired
+                })
+            ).isRequired
+        })
+    ).isRequired,
     testPlanVersions: PropTypes.array,
     triggerUpdate: PropTypes.func
 };

diff --git a/client/components/TestQueue/queries.js b/client/components/TestQueue/queries.js
@@ -28,6 +28,7 @@ export const TEST_QUEUE_PAGE_QUERY = gql`
             }
             browsers {
                 id
+                key
                 name
             }
             candidateBrowsers {
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,6 +28,7 @@ export const TEST_QUEUE_PAGE_QUERY = gql` @@
                 }
                 browsers {
                     id
+                    key
                     name
                 }
                 candidateBrowsers {
@@ Expand Down @@